Remove accesses to global placement state during placement stage #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…locs with get_block_locs()
|
@vaughnbetz and @AlexandreSinger |
There was a problem hiding this comment.
Hi @soheilshahrouz this looks good to me. I left some non-functional comments.
it will be destructed when going out of scope
vaughnbetz
requested changes
Aug 6, 2024
| @@ -712,7 +712,7 @@ bool TimingReporter::nearly_equal(const Time& lhs, const Time& rhs) const { | |||
|
|
|||
| size_t TimingReporter::estimate_point_print_width(const TimingPath& path) const { | |||
| size_t width = 60; //default | |||
| for(auto subpath : {path.clock_launch_path(), path.data_arrival_path(), path.clock_capture_path()}) { | |||
| for(const auto& subpath : {path.clock_launch_path(), path.data_arrival_path(), path.clock_capture_path()}) { | |||
There was a problem hiding this comment.
Pushing back to tatum is OK; it's leading user is VTR. But I agree this should be pushed back if you change it.
vaughnbetz
requested changes
Aug 6, 2024
… methods of BlkLocRegistry
|
CI is down. How about you run VTR and Titan again to make sure they're still fine (almost certainly are); if they look good go ahead and merge. Also, please push back Tatum. |
|
Re-launched CI. |
|
@vaughnbetz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all accesses to
g_vpr.placement()member variables that contain information about block locations and are subject to change during the placement stage. Block location information is instead stored in a local object that is copied into the global placement state at the end of the placement stage.Motivation and Context
Using local objects to store block locations is the first step to run multiple instances of annealer in parallel. With this PR, each annealer can have its own
block_locs,grid_blocks, andpin_locations.How Has This Been Tested?
In progress
Types of changes
Checklist: